[aur-general] Hello from Jethro, and could someone take a look at my first pkgbuild?

[Eli Schwartz]

On 07/26/2017 05:13 PM, J3thro via aur-general wrote:
> Hi folks,
> 
> I am very happy that I finally get the chance to join AUR community and
> contribute something. I just adopted an orphan AUR package and submitted my
> first pkgbuild (see https://aur.archlinux.org/packages/pycharm-community/).
> Is there anyone willing to double check that I didn't make stupid mistakes?

Well, it looks like all you did was bump the pkgver, which means all the
stupid mistakes would be the fault of the previous maintainer. :D

My main objection would be that $srcdir and $pkgdir are not properly
quoted. Likewise with $startdir, except that that is deprecated and it
should be accessing the .desktop file from $srcdir instead.

-- 
Eli Schwartz

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.archlinux.org/pipermail/aur-general/attachments/20170726/0d5bbbcf/attachment.asc>