[aur-general] Hello from Jethro, and could someone take a look at my first pkgbuild?

[J3thro]

Hi Eli, David,

Thank you very much for the critiques.

1) I fixed the arch field, 2) moved the cython into the build function, and
3) fixed the startdir. One thing I do noticed is that the namcap is very
vague about the errors, I have to manually figure out where and what is
wrong there. Is there some other tools? (looks like pkglint doesn't have a
aur pkg yet?)


On Wed, Jul 26, 2017 at 6:18 PM, Eli Schwartz <eschwartz at archlinux.org>
wrote:

> On 07/26/2017 06:04 PM, David Phillips wrote:
> > You have in your PKGBUILD
> >
> >     arch=('any')
> >
> > and then later
> >
> >     if [[ $CARCH = 'i686' ]]; then
> >         …
> >
> > Are these not contradictory? Or am I overlooking something?
>
> Nope, and I'm not sure why I missed that either, this is definitely
> something namcap/pkglint would complain about as well.
>
> ...
>
> Continuing to look at that PKGBUILD, I also notice it seems to build a
> Cython extension, in which case, cython really needs to be a
> makedepends. Also that part should be done in a build() function rather
> than package()
>
> --
> Eli Schwartz
>
>