[aur-general] gopro package check

[Eli Schwartz]

On 06/28/2017 05:08 PM, mickael foucaux via aur-general wrote:
> Hi !
> 
> I just realized my first PKGBUILD for gopro tool  which is available here
> for now: https://github.com/mickro/gopro-tools-arch-package
> 
> Gopro tools are made by https://github.com/KonradIT. That gives some useful
> tools for GoPro post production. And I think that can be usefull for many.
> 
> I'm asking here for a PKGBUILD review, as suggested on
> https://wiki.archlinux.org/index.php/Arch_User_Repository#Submitting_packages

You're downloading the source directly from master, which means this
package will fail the integrity checksums as soon as there is any sort
of update.

Where do you even get a version number from? The source repository has
no tags... if it did have a tag, you could download the tagged release!
Therefore, this should be a *-git package, and you should download the
repository as a whole via git, then use the pkgver function from
https://wiki.archlinux.org/index.php/VCS_package_guidelines

$srcdir and $pkgdir are not quoted. What do you think will happen if I
try building this package from "$HOME/aur packages/gopro-tools/"?

Your PKGBUILD claims the package is licensed under the GPL3 but I cannot
find any trace of a license in the upstream repository.

-- 
Eli Schwartz

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.archlinux.org/pipermail/aur-general/attachments/20170628/dc2ed890/attachment.asc>