[aur-general] Review and a bit of other help request

[Eli Schwartz]

On 03/22/2017 09:53 PM, Konstantin Gizdov wrote:
> Hi again,
> 
> So I updated xrootd and pythia and submitted the relevant deletion
> requests. Now, can I get some package reviews? Thanks.

I know nothing about the specific packages in question, so I will merely
make some general PKGBUILD comments.

${srcdir} and ${pkgdir} must *always* be shell-quoted, as they are
user-controlled filepaths and can contain whitespace.

update-desktop-database, update-mime-database, gtk-update-icon-cache are
pacman hooks, remove them from the root5 install file. You can probably
also drop the pre-remove stuff by now, thereby getting rid of the
install file altogether. (yay!)

Some of your other install files imply that optional dependencies
require being installed at build-time, in which case you should simply
add them as makedepends. If that support means you cannot then uninstall
them (e.g. linking to shared libraries) then they should not be optional
at all. Automagic dependencies are *evil* and should be explicitly
enabled or explicitly disabled.

You use `[[ -d $dir ]] || mkdir $dir` several times, you can just use
`mkdir -p $dir` which does not error when $dir already exists (and
creates parent directories as needed also...).

Make already knows how to read $MAKEFLAGS, no need to specify it on the
command line.

xrootd uses `cmake ... || return 1`, and `make || return 2`, why???
makepkg already knows how to abort as soon as *any* error occurs.

Do not list make as a makedepends, it is assumed users will have
base-devel already installed for building packages.

In root5, I would probably turn $sys_libs into a bash array on general
principle, since bash knows how to expand them into arguments without
depending on ugly things like word-splitting of a variable.
```
declare -a sys_libs
for sys_lib in ...; do
   sys_libs+=("--disable-builtin-${sys_lib}")
done

./configure ... "${sys_libs[@]}"
```

-- 
Eli Schwartz

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.archlinux.org/pipermail/aur-general/attachments/20170322/a84e5abb/attachment.asc>