[aur-general] TU Application: Andrew Crerar

[Andrew Crerar]

On 11/20/17 8:18 PM, Eli Schwartz wrote:
> On 11/17/2017 07:22 AM, Andrew Crerar wrote:
>> Hi Everyone!
>>
>> My name is Andrew Crerar (aka andrewSC) and I'm applying to become a
>> Trusted User. Big thanks to Johannes Löthberg for being my sponsor!
>> :)
>>
>> At the moment I'm a Research Software Engineer at The Laboratory for
>> Analytic Sciences [1] where I primarily write Python 3.x (in
>> combination with various other tech like nginx, gunicorn,
>> elasticsearch, etc.) for the prototypes we're building here. Prior to
>> working at the lab I was a Software Engineer and Computer Scientist
>> at Adobe Inc. [2] where I lead and managed the development of Custom
>> Creative Networks [3] (primarily PHP with some JS heavy elements) on
>> the Behance [4] team. My Bachelor's degree is in Computer Science
>> which I received from The Rochester Institute of Technology [5].
>>
>> I've been using Arch Linux since 2008-2009ish and have seen it grow
>> into something incredible. Over the past several years I've picked up
>> a handful of packages [6] in the AUR which I enjoy maintaining. I
>> also participate in package signoffs for [core], [extra], and
>> [community]. I wish to grow my ability to contribute by becoming more
>> involved in maintaining and managing the AUR while also making
>> contributions to [community] where appropriate.
> 
> Nice to see you applying, and good luck! :)

Thanks :)

> 
> Some quick comments on your AUR packages, but they basically look fine.
> 
> git-git:
> - consider adding the latest systemd service changes from [extra]/git

Done.

> - Why does this depend on glib2-git

Initially it was because Namcap reported that glib2-git (which provided 
libgobject-2.0.so.0 and libglib-2.0.so.0) was needed for the files 
git-core/git-credential-libsecret and git-core/git-credential-gnome-keyring. 
Honestly it didn't need to be glib2-git as glib2 from [core] would work just as 
well in providing those libs. Seeing as libsecret from [core] has a dependency 
on glib2 I'll take glib2-git out and put libsecret in the optdepends array.

> - why are libgnome-keyring and libsecret hard dependencies for people
>    not using those helpers?

You're right, these should be optdepends. Also I took the liberty of removing 
libgnome-keyring as it's deprecated [1].

> - Why go to all that extra effort to create a sysusers configuration
>    when the benefit of using sysusers is removed by the need to set a
>    login shell... which you do not add to /etc/shells? In the event that
>    the sysusers configuration is ever made use of, the shell will still
>    need to be fixed.

I double checked this one and I am adding git-shell to /etc/shells within the 
install file [2]. This is the same behavior as git in [extra] [3].

> 
> gtk4-git:
> - url redirects to HTTPS version, this is really an [extra] issue

Fixed.

> 
> opencv-git:
> - url redirects to HTTPS version, this is really an [extra] issue

Fixed.

> - The repo package has hdf5 as a makedepends/optdepends, why is this a
>    depends? More importantly... why is it also still an optdepends?

I dug around a bit and found this ticket [4] where it seems if you didn't have 
hdf5 as a makedepends, then the build would fail (I personally don't think it 
should have failed given the documentation [5]). This really should be 
optdepends now since you can build without it. Fixed. I also took the liberty of 
adding opencv-samples to the conflicts array (since opencv-git provides samples 
without the split package).

> 
> ttf-google-fonts-git:
> - `install -dm755 ...; install -Dm644 ...;` is kind of like sprinkling
>    your code with `sleep 1`

Fixed.

> - Instead of copying licenses to a per-font subdirectory, I would use
>    LICENSE.$fontname

Fixed.

> 
> vlc-git:
> - Mercy on your soul for having the bravery to touch VLC, I'm skipping
>    this one. :D Nothing jumps out at me anyway.

;)


[1] https://wiki.gnome.org/Projects/Libsecret
[2] https://aur.archlinux.org/cgit/aur.git/tree/git-git.install?h=git-git#n7
[3] 
https://git.archlinux.org/svntogit/packages.git/tree/trunk/git.install?h=packages/git#n11
[4] https://bugs.archlinux.org/task/50111
[5] https://docs.opencv.org/master/d3/d23/classcv_1_1hdf_1_1HDF5.html#details

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <https://lists.archlinux.org/pipermail/aur-general/attachments/20171121/bc0ff547/attachment.asc>