[aur-general] [Review Request] PKGBUILD for bumblebee-status

[Tobias Witek]

Hi,

thanks a lot for the quick responses - and in particular for the 
improved version (and for the checksum improvements in the other mail)! 
I will look into adding it to AUR with the suggested improvements right 
away.

With a community that friendly, I'm now seriously considering switching 
to Arch :-)

Thanks!

Tobias

On 09/17/2017 01:48 PM, Daniel Capella via aur-general wrote:
> Input: https://ptpb.pw/7YEJ
> Output: https://ptpb.pw/-L5i
> 
> On Sun, Sep 17, 2017 at 6:42 AM, Lex Black <autumn-wind at web.de> wrote:
> 
>> Hi
>>
>> Some issues I noticed:
>> In this case you should remove the conflict and the provides line. And the
>> _pkgname variable does not differ from pkgname so it should be removed too.
>> The prefixed v in the pkgver should be removed.
>> Regarding downloading the source there is a Arch-Wiki page for VCS
>> packages.
>> Three choices regarding this specific case. You can directly download the
>> tar archive tied to the tag, append the current source with #tag=v${pkgver}
>> or with #commit= followed by the commit hash tied to the tag.
>> The latter being preferred IIRC to avoid the issue with retagging.
>> If doing the first, the source line should be prefixed with
>> ${pkgname}-${pkgver}:: to make the file name of the downloaded tar archive
>> unique.
>>
>> All three make the git command usage in package() obsolete.
>>
>> Best regards
>> Lex
>>
> 
> 
>