[aur-general] Issue with proper packaging

[Konstantin Gizdov]

Yeah, forgot about that too... I guess one of those days. Fixed now. Thanks
for the help.

Regards,
Konstantin

On Wed, Feb 21, 2018 at 2:43 PM, Ankit R Gadiya <arch at argp.in> wrote:

> Hey,
>
> But anybody using the package is pulling the git repository and so it
> automatically uses the master HEAD, and I don't see any command in
> prepare() for choosing the commits.
>
>
> On 02/21/2018 07:07 PM, Konstantin Gizdov wrote:
>
>> Hi Morgan,
>>
>> Indeed on the surface it looks that way. The dev does not explicitly make
>> releases anymore for some reason, but I work with him and I know which
>> commits are actually supposed to be releases and only choose those.
>>
>> Regards,
>> Konstantin
>>
>> On Wed, Feb 21, 2018 at 2:19 PM, Morgan Adamiec via aur-general <
>> aur-general at archlinux.org> wrote:
>>
>> On 21 February 2018 at 13:14, Bruno Pagani via aur-general
>>> <aur-general at archlinux.org> wrote:
>>>
>>>> Le 21/02/2018 à 13:55, Konstantin Gizdov a écrit :
>>>>
>>>> Hi,
>>>>>
>>>>> I'm having trouble making a package under the Arch Packaging Standards.
>>>>>
>>>> The
>>>
>>>> package in question is `simpletools`.
>>>>>
>>>>> The problem I'm having is that if I use `prepare()` & `build()`
>>>>>
>>>> directives
>>>
>>>> as intended, then the target `make install` does not exist when called
>>>>>
>>>> from
>>>
>>>> inside `package()` directive. I'm wondering if this is an issue because
>>>>>
>>>> of
>>>
>>>> the way `makepkg` pulls it over git and later handles it, or is it some
>>>>> problem with the CMake configuration in the software itself?
>>>>>
>>>>> I haven't been able to replicate this in a manual way, because
>>>>> obviously
>>>>> when run manually the configuration is persisted locally. Any comments?
>>>>>
>>>>> --
>>>>> Regards,
>>>>> Konstantin
>>>>>
>>>>
>>>> Can you provide the new PKGBUILD so we can see what is wrong? I guess
>>>> the issue is you are not replacing makepkg at the right place in each
>>>> function.
>>>>
>>>> Note that makepkg will indeed start in ${srcdir} at the beginning of
>>>> each PKGBUILD functions (`prepare()`, `build()`, `package()`,
>>>> `check()`).
>>>>
>>>> Regards,
>>>> Bruno
>>>>
>>>>
>>> Your package appears to pull directly from git and not a specific
>>> release so it should probably be named `-git` and include a `pkgver()`
>>> function.
>>>
>>>
> --
> From: Ankit R Gadiya <https://ankitrgadiya.in>
>