[aur-general] amiwm PKGBUILD file

[DJ Lucas]

On 01/23/2018 04:15 PM, DJ Lucas wrote:
> On January 23, 2018 3:59:24 PM CST, Panayotis Katsaloulis via aur-general <aur-general at archlinux.org> wrote:
>> Hello all
>>
>> This is my first attempt to create a valid PKGBUILD file for Arch
>> Linux.
>> It is about the missing amiwm window manager.
>>
>> Please tell me what you think
>>
>>
>>
>> # Maintainer: Panayotis Katsaloulis <panayotis at panayotis.com>
>> pkgname=amiwm
>> pkgver=0.21pl2
>> pkgrel=1
>> pkgdesc="An X window manager that tries to make your display look and
>> feel like an Amiga® Workbench® screen"
>> arch=('x86_64' 'i686')
>> url="https://www.lysator.liu.se/~marcus/amiwm.html"
>> license=('FREEWARE')
>> source=('ftp://ftp.lysator.liu.se/pub/X11/wm/amiwm/amiwm0.21pl2.tar.gz')
>> md5sums=('3a47e887777e2be2978363220cf815ef')
>>
>> build() {
>>     cd "$pkgname$pkgver"
>>     ./configure --prefix=/usr
>>     make
>> }
>>
>> package() {
>>     cd "$pkgname$pkgver"
>>     make prefix="$pkgdir/usr" install
>>     rm $pkgdir/usr/bin/requestchoice
>>    install -Dm644 LICENSE "$pkgdir"/usr/share/licenses/$pkgname/LICENSE
>> }
> 
> License should be custom, you should use $pkgver in the URL (will save you a step when you update it), and you need to provide dependency info (at very least Xorg, but most likely more).
> 
> HTH
> 

Also, having built it, it looks like the smallest inclusive dependency 
is just libxmu by itself. Finally, the manuals should be installed in 
/usr/share/man, not /usr/man. Append the following:

     mv -v "${pkgdir}/usr/man" "${pkgdir}/usr/share"

Use of curly braces (unnecessary in this case) and placement of the 
quote marks above are to taste. Another thing, again only to taste, is 
always using '-v' in mv, cp, ln, and install commands (probably others), 
but if something goes wrong, it gives the user more to go on and shows 
up in the build log.

--DJ