[aur-general] RFC: PKGBUILD for nixnote2-git [Take 3]

[Florian Bruhin]

On Sun, Oct 07, 2018 at 04:32:04PM +0700, Tom Hale wrote:
> Comments please.

Some random stuff I noticed:

> _repo_url="https://github.com/robert7/${_pkgname}.git"

Probably not needed when you only need it in source.

> provides=("nixnote=${pkgver%.r*}" "nixnote2=${pkgver%.r*}")

Guess you could use $_pkgname here for nixnote2. Also not sure
specifying the version there is a good idea.

> set -o pipefail

That seems like a good idea, but I'm not sure a PKGBUILD should set it.
Maybe makepkg even does it by itself?

>   echo "Building package: $_pkgname-$pkgver" >&2

makepkg already should give you output like that.

>   /usr/bin/qmake PREFIX=/usr

Why /usr/bin/qmake and not just qmake?

>   # Strip the binary to save 160MB of disk
>   strip qmake-build-release/"$_pkgname"

makepkg should already do that.

>   install -Dm644 shortcuts.txt "${pkgdir}/usr/share/doc/$_pkgdir/shortcuts_sample.txt"
>   install -Dm644 docs/{shortcuts-howto,CHANGELOG}.md "${pkgdir}/usr/share/doc/$_pkgdir/"

What's _pkgdir? That sounds like you mean _pkgname.

Florian

-- 
https://www.qutebrowser.org | me at the-compiler.org (Mail/XMPP)
   GPG: 916E B0C8 FD55 A072 | https://the-compiler.org/pubkey.asc
         I love long mails! | https://email.is-not-s.ms/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.archlinux.org/pipermail/aur-general/attachments/20181007/2fd9bfae/attachment-0001.asc>