[aur-general] Critique my pkgbuild

Eli Schwartz eschwartz at archlinux.org
Wed Oct 10 13:55:52 UTC 2018

On 10/10/18 9:52 AM, Tinu Weber wrote:
> On Wed, Oct 10, 2018 at 15:48:31 +0200, Morten Linderud via aur-general wrote:
>>> makedepends=('make')
>> `make` is present in `base-devel` thus shouldn't be a listed dependency. Unsure
>> if its however worth listing it as it's the only needed build-time dependency?
> As it is a git package (and git is not in base-devel), I would argue
> that at least 'git' should go in there.

In fact, the current PKGBUILD has git as a makedepends because you need
it in order to clone the source.

Programs used for downloading the source must be specified in
makedepends unless it is curl since curl is a dependency of the pacman

Eli Schwartz
Bug Wrangler and Trusted User

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.archlinux.org/pipermail/aur-general/attachments/20181010/3327c693/attachment.asc>

More information about the aur-general mailing list