[aur-general] PKGBUILD rfc

[Robin Broda]

On 8/5/19 9:51 AM, Vladimir Bauer via aur-general wrote:
> Hi!
> 
> I have a PKGBUILD I would like to submit:
> https://github.com/vbauerster/getparty-PKGBUILD
> 
> What is further steps?
> 

pacman, sudo, and git are not dependencies of your package.
They should not be in depends=()

The PKGBUILD does not follow the golang packaging guidelines outlined on our wiki.

The git ls-remote dance in build() makes no sense. Pull the source from git directly instead.
(If you do that, git becomes a makedep)

Stylistically, pkgdesc shouldn't end on punctuation.

References to $srcdir are redundant in your entire PKGBUILD.

-- 
Rob (coderobe)

O< ascii ribbon campaign - stop html mail - www.asciiribbon.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <https://lists.archlinux.org/pipermail/aur-general/attachments/20190805/fd8e04b1/attachment.sig>