[aur-general] PKGBUILD rfc

[Vladimir Bauer]

Just FYI,
It's not mandatory to export GOPATH with latest go 1.12.
So I reckon guide at
https://wiki.archlinux.org/index.php/Go_package_guidelines is out of date.
Example there is doing much dancing around exporting GOPATH, which is
unnecessary at all.

On Tue, Aug 6, 2019 at 9:53 AM Vladimir Bauer <vbauerster at gmail.com> wrote:

> Thank all for comments!
> I was referring to
>
> https://aur.archlinux.org/yay.git
>
> as a source of truth of golang PKGBUILD.
>
>
> On Mon, Aug 5, 2019 at 5:06 PM Robin Broda via aur-general <
> aur-general at archlinux.org> wrote:
>
>> On 8/5/19 9:51 AM, Vladimir Bauer via aur-general wrote:
>> > Hi!
>> >
>> > I have a PKGBUILD I would like to submit:
>> > https://github.com/vbauerster/getparty-PKGBUILD
>> >
>> > What is further steps?
>> >
>>
>> pacman, sudo, and git are not dependencies of your package.
>> They should not be in depends=()
>>
>> The PKGBUILD does not follow the golang packaging guidelines outlined on
>> our wiki.
>>
>> The git ls-remote dance in build() makes no sense. Pull the source from
>> git directly instead.
>> (If you do that, git becomes a makedep)
>>
>> Stylistically, pkgdesc shouldn't end on punctuation.
>>
>> References to $srcdir are redundant in your entire PKGBUILD.
>>
>> --
>> Rob (coderobe)
>>
>> O< ascii ribbon campaign - stop html mail - www.asciiribbon.org
>>
>>
>
> --
> Kind Regards,
> Vladimir Bauer
>


-- 
Kind Regards,
Vladimir Bauer