[aur-general] Trusted user application: Drew DeVault

[Brett Cornwall]

On 2019-02-24 18:24, Drew DeVault via aur-general wrote:
>Hiya! Jerome convinced me to finally apply for TU, and Sven-Hendrik
>agreed to co-sponsor my application (both Cc'd).

I must jokingly admit that my first instinct is to vote against your 
application so that you'd spend more time on wlroots and Sway. You're 
not allowed to work on anything else, slave!



>I maintain the following AUR packages:
>
>https://aur.archlinux.org/packages/?SeB=m&K=sircmpwn

Here's a PKGBUILD review:

## In general
* Prefer sha256sums over sha1sums and md5sums [1]
* "$srcdir" can often be omitted as the PKGBUILD functions all begin in "$srcdir" already - this will make PKGBUILDs much more readable
* MIT-licensed packages are not installing their licenses. [2]
* i386/i686 architectures should be removed.
* update python-distribute makedeps to python-setuptools
* source= lines should save sources to a "$pkgname-$pkgver.tar.gz" file, e.g.

    source=("$pkgname-$pkgver.tar.gz::https://github.com/KnightOS/genkfs/archive/${pkgver}.tar.gz")


## knightos-sdk
Python distutil packages should be built and packaged separately [3]:

    build() {
        python setup.py build
    }

    package() {
        python setup.py install --root="$pkgdir/" --optimize=1 --skip-build
    }


## madonctl
* I'm never fond of overly abstracting random things in $_variables 
unless it serves a purpose. This is more style/opinion, though.


## python-activipy-git
* No need to include the GPL3 text, it's one of the included licenses in arch.
* Quote your variables!
* makedepends should include python-setuptools
* source and url have https, so use it!
* I'm seeing an apache license in the repo as well as gpl3


## python-flask-markdown, python-haxor
* source has https, so use it!


## python-pystache
* see madonctl.
* `|| exit 1` is useless here.
* URL should use https


## python-spam-blocklists
* fill that depends() list, I'm sure it needs something.


## vgo-git
What's with these custom functions? Why not just put this stuff in 
prepare() like the packaging guidelines? [4]



[1] https://wiki.archlinux.org/index.php/PKGBUILD#Integrity
[2] https://wiki.archlinux.org/index.php/PKGBUILD#license
[3] https://wiki.archlinux.org/index.php/Python_package_guidelines#distutils
[4] https://wiki.archlinux.org/index.php/Go_package_guidelines#PKGBUILD_with_GOPATH_and_dep
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 248 bytes
Desc: not available
URL: <https://lists.archlinux.org/pipermail/aur-general/attachments/20190224/c861dea9/attachment.sig>