[aur-general] Exact purpose of check()

[Eli Schwartz]

On 1/2/19 9:44 AM, Julien Nicoulaud via aur-general wrote:
> Hi,
> 
> There is a bit of debate at the borgmatic package (
> https://aur.archlinux.org/packages/borgmatic) about what check() should do.
> The upstream borgmatic project uses tox to execute its tests. tox creates
> an isolated python virtualenv with the correct dependency versions and
> executes tests in there.
> 
> The original maintainer thinks check() should not use tox so that tests can
> be run against the system installed dependencies. But this is not so easy
> to do, an attempt was made by installing the python package into an
> isolated directory just for tests, but even then it seems to conflict with
> an existing borgmatic installation.
> 
> Another way of seeing things is that check() should just run tests the way
> it is intended by upstream, it is for testing the build artifacts are
> correct, not for testing it will run correctly on the system where it is
> built. By this logic check() should just run tox, and correct dependency
> versions can be enforced by using version ranges in "depends".
> 
> Any advice on this ?

1) But upstream already runs tox in order to check that the source code
   is well-formed.

2) The PKGBUILD check() function is part of the packaging process for
   packaging software with Arch Linux, it is not part of the upstream
   development process for creating generic, cross-platform, PyPI
   uploads.

-- 
Eli Schwartz
Bug Wrangler and Trusted User

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.archlinux.org/pipermail/aur-general/attachments/20190102/396d40c1/attachment.asc>