[aur-general] rfc: pkgbuild for prospect releng-tool

[James Knight]

Hello -- new user to AUR and hoping if anyone is willing to review a
PKGBUILD [1] definition for me. I have been reading PKGBUILD [2] and
"AUR - Submitting packages" [3] documents, which the latter document
suggests to "... submit the PKGBUILD to the AUR mailing list ... for
public review before adding it to the AUR".

The following is my prospect PKGBUILD definition if anyone has time to
make comments/suggestions:

---
# Maintainer: James Knight <james.d.knight at live.com>

pkgname=releng-tool
pkgver=0.1
pkgrel=1
pkgdesc='tool to assist in the release engineering of a project'
url='https://releng.io/'
arch=('any')
license=('BSD')
makedepends=(
     'python'
)
source=("$pkgname-$pkgver::git+https://github.com/releng-tool/releng-tool.git#tag=v$pkgver")
sha512sums=('SKIP')

build() {
   cd "$pkgname-$pkgver"
   python setup.py build
}

check() {
   cd "$pkgname-$pkgver"
   python setup.py test
}

package() {
   depends=('python')
   cd "$pkgname-$pkgver"
   python setup.py install --root="$pkgdir" --optimize=1

   install -Dm644 LICENSE "$pkgdir/usr/share/licenses/$pkgname/LICENSE"
   install -dm 755 "$pkgdir/usr/share/bash-completion/completions"
   install -m644 scripts/releng-tool-completion 
"$pkgdir/usr/share/bash-completion/completions/releng-tool"
}
---

Please be merciless.

[1]: 
https://github.com/releng-tool/releng-tool-pkgbuild/blob/master/PKGBUILD
[2]: https://wiki.archlinux.org/index.php/PKGBUILD
[3]: 
https://wiki.archlinux.org/index.php/Arch_User_Repository#Submitting_packages