[aur-general] rfc: pkgbuild for prospect releng-tool
Brett Cornwall
brett at i--b.com
Wed Mar 6 06:57:43 UTC 2019
On 2019-03-05 23:53, Brett Cornwall wrote:
>>url='https://releng.io/'
>>arch=('any')
>>license=('BSD')
>
>I don't see this license in the project. It needs to be in the
>project, and if it is indeed BSD licensed you need to copy the license
>to "$pkgdir/usr/share/licenses/$pkgname/" [1]
Oops... I suck at computers and managed to end up in the
releng-tool-examples repo. I should go to bed. So I see that the license
is indeed in upstream and you've included it in the package. Derp.
>>source=("$pkgname-$pkgver::git+https://github.com/releng-tool/releng-tool.git#tag=v$pkgver")
>
>I see that you're the maintainer of upstream; Why not create a release
>on Github and then download the tarball here? Typically, pulling
>sources via git is for '-git' packages.
You should use the release tarball instead of relying on git then, which
would be another dependency in this package.
>>sha512sums=('SKIP')
>
>Having a tarball release will mean that you can have checksum
>verification as well.
^Still applies.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 248 bytes
Desc: not available
URL: <https://lists.archlinux.org/pipermail/aur-general/attachments/20190305/d106ce02/attachment.sig>
More information about the aur-general
mailing list