[aur-general] review of getax2019 PKGBUILD

[Doug Newgard]

On Sun, 23 Feb 2020 13:17:44 +0100
Yoan Blanc via aur-general <aur-general at archlinux.org> wrote:

> Hi folks,
> 
> I've built my first PKGBUILD based on Brunio Renié's vaudtax,
> https://aur.archlinux.org/packages/vaudtax/
> 
> https://gitlab.com/greut/getax
> 
> Do you think I could propose it as is to aur-request? Do you see anything
> that could be improved?
> 
> Cheers,
> 

You should not be downloading anything in the prepare function if it can be
avoided. $_pkgver is being added to the downloaded filename, does it not
contain the updates? If this is really necessary, it should all be in the
source array.

Pick a variable style and stick with it. Some have braces, some don't.

Make sure to quote all variables that you don't control and could contain
spaces.

Get rid of the empty build function.

Why call cp 3 times when once would do it?

Don't use tabs for alignment (sha256sums).

aur-requests is a mailing list for automated listing of requests for people to
reply to. You don't send new threads to it directly, and the requests in
question are only deleting package or merging them into other packages, it's
not what you want here. You just need to use the comments.