[aur-requests] [PRQ#11370] Merge Request for mcpelauncher-git

[Robin Broda]

On 05/12/2018 10:51 PM, notify--- via aur-requests wrote:
> ErnyTech [1] filed a request to merge mcpelauncher-git [2] into
> mcpelauncher-erny [3]:
> 
> I remade the package to clean it up

The AUR isn't github. Don't do this.
Read the rules of submission[1] for AUR packages,
as it stands - you're breaking several of these.

Additionally, your PKGBUILD is invalid & bad.
Have you ever tried building your package?

You're missing 'git' as makedep, your license is invalid,
you're not declaring conflicts with the original package even though it does,
your variable expansions are unquoted - breaking paths with spaces,
you're explicitly `strip`ping the libraries in build(),
you're creating global variables you're only ever using once,
& you're not following the standard naming conventions.

If anything, this marks your clone for deletion.

Rob

[1] https://wiki.archlinux.org/index.php/Arch_User_Repository#Rules_of_submission