[aur-requests] [PRQ#20463] Deletion Request for befungee-git

[Magnus Boman]

On 26/07/2020 14:50, Anton Leontiev wrote:
> <notify at aur.archlinux.org <mailto:notify at aur.archlinux.org>>:
> 
>     katt [1] filed a deletion request for befungee-git [2]:
> 
>     Using legacy git download method instead of proper source
> 
>     [1] https://aur.archlinux.org/account/katt/
>     [2] https://aur.archlinux.org/pkgbase/befungee-git/
> 
> 
> I don't understand the reason. Package builds successfully.
> 
> Please don't delete the package. Post a comment to update PKGBUILD instead.
> 
> Best regards,
> Anton Leontiev

While it may build successfully, it is not done properly. You should be 
using the source array for downloading, as specified in the guidelines.

Furthermore your PKGBUILD is lacking a pkgver() function, no contact 
details (template still in place) and all that sed'ing should perhaps be 
in prepare() instead, but that of course must wait until you stop 
abusing build().

I recommend taking a good read through the VCS packaging guidelines:
https://wiki.archlinux.org/index.php/VCS_package_guidelines

Cheers, katt.