[pacman-contrib] [PATCH] paccache: Skip .sig files when globbing candidates for removal

[Eli Schwartz]

On 02/22/2018 05:52 PM, Maxim Baz wrote:
> On 02/22/2018 10:05 PM, Johannes Löthberg via pacman-contrib wrote:
>> Thanks for the patch, but could we use "$PWD"/*.pkg.tar!(*.sig) instead 
>> of using grep for this? It makes the glob a bit more obvious to me as 
>> well.
> 
> Yes, this is way better, and I confirm that results are the same - will send out the modified patch shortly.
> 
> 
> 
> On 02/22/2018 11:07 PM, Eli Schwartz via pacman-contrib wrote:
>> Sorry, this was only partially true. The patch was broken anyways
>> because of linebreaks and other fun chars, but my issue with it being an
>> "attachment" is because this list seems to have been configured to relay
>> messages as message/rfc822. As Johannes pointed out, this is the
>> technically correct way to preserve DKIM signatures when the mailing
>> list modifies the From and Subject lines to add the list name into the
>> subject... if only every client out there (or even most of them)
>> actually supported it...
> 
> Yeah, the first patch was completely broken, it was the first time I sent git patches via email and I didn't know about all the problems that email clients cause to the patches :) Was the second patch good though?

The second patch was fine, yes.

-- 
Eli Schwartz
Bug Wrangler and Trusted User

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.archlinux.org/pipermail/pacman-contrib/attachments/20180222/751e6007/attachment-0001.asc>