[pacman-dev] [PATCH] libalpm: more verbose error messages on file conflicts

[Aurelien Foret]

VMiklos wrote:
> http://frugalware.org/~vmiklos/patches/libpacman-proposed/verbose_conflicts.diff
> 
>   currently:
>   $ sudo pacman -S foomatic-filters-ppds --noconfirm
>   resolving dependencies... done.
>   looking for inter-conflicts... done.
>   
>   Targets: foomatic-filters-ppds-20051211-1
>   
>   Total Package Size:   11.5 MB
>   
>   Beginning upgrade process...
>   
>   checking package integrity... done.
>   ERROR: could not prepare transaction
>   error: failed to commit transaction (unexpected error)
>   
>   expected:
>   $ sudo pacman -S foomatic-filters-ppds --noconfirm
>   resolving dependencies... done.
>   looking for inter-conflicts... done.
>   
>   Targets: foomatic-filters-ppds-20051211-1
>   
>   Total Package Size:   11.5 MB
>   
>   Beginning upgrade process...
>   
>   checking package integrity... done.
>   ERROR: foomatic-filters-ppds: /usr/share/ppd: exists in filesystem
>   ERROR: could not prepare transaction
>   error: failed to commit transaction (conflicting files)
> 
> the patch mentioned above implements this

Well, with the latest CVS code, this patch does not seem to be needed 
anymore: src/pacman/add.c is already doing the job to display 
conflicting files (see the PM_ERR_FILE_CONFLICTS case in the 
switch(pm_errno) block).

It all looks like the PM_ERR_XXX error code was preventing the switch to 
reach the aforementionned error case.
--
Aurelien