[pacman-dev] Warning : broken BACKUP handling in 3.1 ?!

[Xavier]

On Sat, Aug 25, 2007 at 03:59:36PM +0200, Xavier wrote:
> After installing filesystem, here is what I get in the database :
> %BACKUP%
> etc/fstab 0d3cfed6eacf21072e468bb7fe80cf07
> etc/crypttab
> etc/group
> etc/hosts
> etc/ld.so.conf
> etc/passwd
> etc/shadow
> etc/gshadow
> etc/resolv.conf
> etc/motd
> etc/nsswitch.conf
> etc/shells
> etc/host.conf
> etc/securetty
> 
> I tried with a few others as well, it seems like only the first entry get a md5sum.

Well, looks like a little typo was made when copy/pasting code on that last
big refactoring :)
I think this is probably totally harmless, it should just cause a few extra
.pacnew files to be extracted.


>From cf0aa0ca29db4de388a8a5c1d76cc0604547d47e Mon Sep 17 00:00:00 2001
From: Chantry Xavier <shiningxc at gmail.com>
Date: Sat, 25 Aug 2007 16:26:41 +0200
Subject: [PATCH] libalpm/add.c : fix backup handling.

During last refactoring, a "continue" somehow became a "return(0)" :)

Signed-off-by: Chantry Xavier <shiningxc at gmail.com>
---
 lib/libalpm/add.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lib/libalpm/add.c b/lib/libalpm/add.c
index 398839a..d361873 100644
--- a/lib/libalpm/add.c
+++ b/lib/libalpm/add.c
@@ -519,7 +519,7 @@ static int extract_single_file(struct archive *archive,
 				backups = alpm_list_next(backups)) {
 			char *oldbackup = alpm_list_getdata(backups);
 			if(!oldbackup || strcmp(oldbackup, entryname) != 0) {
-				return(0);
+				continue;
 			}
 			char *backup = NULL;
 			/* length is tab char, null byte and MD5 (32 char) */
-- 
1.5.2.5