[pacman-dev] [PATCH] Clean way to separate local from sync dbs.

[Dan McGee]

On 8/26/07, Travis Willard <travis at archlinux.org> wrote:
> On Fri, 24 Aug 2007 22:40:41 -0400
> Travis Willard <travis at archlinux.org> wrote:
>
> > Here's the quick-and-dirty version of moving repos to
> > $DBPATH/sync/$REPO.
> >
> > I don't much like it, to be honest - I'd prefer to separate the
> > concept of the local repo from the sync repos entirely
>
> And here's my patch to do this.  Read the comment for details - I think
> I was specific enough there.
>
> >From 7d9c73eda546195a0a207be8b264219184929712 Mon Sep 17 00:00:00 2001
> From: Travis Willard <travis at archlinux.org>
> Date: Sun, 26 Aug 2007 12:00:03 -0400
> Subject: [PATCH] Clean way to separate local from sync dbs.
>
> Introduce two new methods into the API - alpm_syncdb_register and
> alpm_localdb_register, which replace the functionality of
> alpm_db_register. which has now been flagged as deprecated.
> localdb_register always returns the local DB, and syncdb_register will
> always try to register a sync DB.  This removes the silly limitation
> that a sync DB couldn't be named 'local', along with structurally
> separating sync DBs and the local DB in the filesystem. Also updated
> the pacman frontend to use the new functions.
>
> Signed-off-by: Travis Willard <travis at archlinux.org>
> ---

I like most of this here, but the patch got nice and malformed so I
can't really take a look at it on my local code tree. Can you resend
it as an attachment perhaps?

And taking a quick look at it, there are a few small things that you
might want to change. The naming prefix of alpm_db should probably
still remain instead of changing it to alpm_localdb (maybe
alpm_db_register_local and alpm_db_register_sync?).

-Dan