[pacman-dev] output issues status
shiningxc at gmail.com
Tue Dec 4 13:11:41 EST 2007
On Mon, Dec 03, 2007 at 06:42:11PM -0600, Dan McGee wrote:
> For now, this looks quite good enough. Great work. You did this as
> cleanly as one would possibly be able to- the only other concern would
> be with a interrupt, which I haven't tested.
> I'm going to let it bake on my working branch tonight (I made a few
> small changes but nothing huge). If everyone could give it a test that
> would be great.
Nothing wrong with your small changes, but it reminded me of something I
the delayed output is only done when --debug is NOT set, because when --debug
is used, the progress bar is disabled with noprogressbar = 1. So in
pm_vasprintf, the logmask will never overlap with LOG_DEBUG or LOG_FUNCTION.
However, that only concerns this particular usage of pm_vasprintf, so you
were right to add LOG_DEBUG and LOG_FUNCTION handling to pm_vasprintf. It
just isn't used currently.
More information about the pacman-dev