[pacman-dev] [PATCH] Compress hard linked man pages
mcrae_allan at hotmail.com
Tue Dec 4 18:54:12 EST 2007
Aaron Griffin wrote:
> On Dec 4, 2007 9:56 AM, Roman Kyrylych <roman.kyrylych at gmail.com> wrote:
>> 2007/12/4, Allan McRae <mcrae_allan at hotmail.com>:
>>> Hi all,
>>> The attached patch fixes FS#5392 . If hard links are present for a
>>> man page, all other hard linked files are removed, the man page is
>>> gzipped and the hard links are updated to the newly compressed man page.
>>> I didn't deal with the comment the .bz2 files are not change because I
>>> felt that is unnecessary. Also, do we even care if man pages have
>>> permission of 444 instead of 644 as mentioned in the final comment?
>>> From the comments in the bug report, the ownership of the traceroute
>>> man page should probably be dealt with in the iputils package and
>>> probably needs a separate bug report opened.
>>> This is the first patch I've submitted and I'm new to git so let me know
>>> if I've done something wrong...
>>>  http://bugs.archlinux.org/task/5392
>> Your patch is named 0001-Signed-off-by-Allan-McRae-mcrae_allan-hotmail.com.patch
>> This is because you didn't add a patch title as a first line.
>> Your commit message should look like this (I numbered lines for clarity):
>> 1 Compress hard linked man pages
>> 2 (empty line)
>> 3 short description goes here
>> 4 and continues here
>> 5 (empty line)
>> 6 Signed-off-by: Allan McRae <youremailaddress>
Fixed. I was a bit lost during that part!
> Besides what Roman mentioned, I noticed you used the backtick inline
> execution syntax - we like to frown on that around here. Could you
> please use $() instead?
Fixed. I didn't know about that syntax - how is it better?
> Other than that, it looks pretty good. This is annoying to repeat though:
> Would it be possible to break that out into a variable or something,
> just for clarity?
New patch attached.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 2547 bytes
Desc: not available
More information about the pacman-dev