[pacman-dev] [PATCH] Compress hard linked man pages

Dan McGee dpmcgee at gmail.com
Tue Dec 4 19:18:52 EST 2007


On Dec 4, 2007 6:06 PM, Aaron Griffin <aaronmgriffin at gmail.com> wrote:
> On Dec 4, 2007 5:54 PM, Allan McRae <mcrae_allan at hotmail.com> wrote:
> > Aaron Griffin wrote:
> > > Besides what Roman mentioned, I noticed you used the backtick inline
> > > execution syntax - we like to frown on that around here. Could you
> > > please use $() instead?
> > >
> > Fixed.  I didn't know about that syntax - how is it better?
>
> Well, first off, backtick expansions is officially deprecated if I
> remember correctly, but at the rate these standards move it will be
> some time before it dies. In addition to hat, $() is much cleaner when
> it comes to parsing and nesting. It's easier to match a pair of
> characters than two of the same characters. Take this for example:
>
>    `foo -c `bar -x``
>    $(foo -c $(bar -x))
>
> The first one might not even parse right in the first place.
>
> > New patch attached.
>
> Danke! It looks good to me. We don't have a testsuite for makepkg like
> we do for pacman, so do you happen to know any packages, offhand, that
> suffer from the hardlink issue, so that I can test this?

I'm making a few changes to the patch locally, and I'll send it here
if it works right.

-Dan




More information about the pacman-dev mailing list