[pacman-dev] Directory permission checking in makepkg

[Allan McRae]

Xavier wrote:
> On Thu, Dec 06, 2007 at 08:06:28AM -0600, Dan McGee wrote:
>   
>> On Dec 6, 2007 7:35 AM, Allan McRae <mcrae_allan at hotmail.com> wrote:
>>     
>>> Hi all,
>>>
>>> I was looking at bug FS#5908 [1] which asks for directory permissions to
>>> be checked somewhere in order to stop screwing your system when
>>> installing a poorly made package (as directory permissions get
>>> overwritten when extracting packages).
>>>
>>> This at first glance seems about a two line addition to the tidy_install
>>> function of makepkg.  However, can anybody come up with a case where
>>> package directories shouldn't have 755 permissions?  If so, I guess this
>>> would require either the addition of some option which would stop the
>>> directory permissions getting fixed (dirperm?) or just checking/fixing
>>> the permissions of a predetermined set of directories. If needed, which
>>> is preferable.
>>>       
>> Pacman itself now does a good amount of permissions checking on
>> install, and I believe it never overwrites an existing directory's
>> permissions. Can anyone else verify this?
>>
>>     
>
> Apparently, you made pacman skip the dir extraction when it already existed.
> Reinstalling filesystem a few times confirm this (with -S or -Sf), <...snip>
OK, I suppose FS#5908 can be closed then.

Thanks,
Allan