[pacman-dev] [PATCH] PM_DEP_MOD_LT and PM_DEP_MOD_GT depmods added

[Aaron Griffin]

On Dec 18, 2007 10:36 AM, Dan McGee <dpmcgee at gmail.com> wrote:
> On Dec 18, 2007 10:08 AM, Xavier <shiningxc at gmail.com> wrote:
> >
> > On Tue, Dec 18, 2007 at 09:57:53AM -0600, Dan McGee wrote:
> > > On Dec 18, 2007 7:26 AM, Nagy Gabor <ngaba at bibl.u-szeged.hu> wrote:
> > > > >From c0d82c952dd7fc59cdc478898025a21d9ecf03d6 Mon Sep 17 00:00:00 2001
> > > > From: Nagy Gabor <ngaba at bibl.u-szeged.hu>
> > > > Date: Tue, 18 Dec 2007 14:24:44 +0100
> > > > Subject: [PATCH] PM_DEP_MOD_LT and PM_DEP_MOD_GT depmods added
> > > >
> > > > You can use foo<2.0 and foo>2.0 as depend
> > > > add046.py and add047.py pactests were added to check this
> > > >
> > > > Signed-off-by: Nagy Gabor <ngaba at bibl.u-szeged.hu>
> > >
> > > Seems fine to me. Aaron, any objections?
> > >
> >
> > I'm not sure you missed this mail, but just in case :
> > http://www.archlinux.org/pipermail/pacman-dev/2007-December/010527.html
> >
> > I have to side with Aaron here, actually, I'm just going to quote what he
> > said :
> > "That said, if someone wants to add in support for > and < comparators,
> > I wouldn't complain. It just sounds like "feature creep" to me - it's
> > solving a problem no one encounters on a day to day basis."
> >
> > That is, I don't find it very useful either, but since it doesn't add much
> > code, it's not a big deal.
>
> Yeah, I saw the email. But it was followed through with a light and
> straightforward patch, so that is why I do not object to merging this
> (although I too do not see a wide range of use for this).

Yup, Nagy kicked ass here. This is great. Like I said, it MAY be a bit
of feature creep, but the code is here and it's not all that much. /me
gives a thumbs up