[pacman-dev] [PATCH] Add check for NULL data parameter in sync commit

Nagy Gabor ngaba at bibl.u-szeged.hu
Sat Dec 22 16:11:49 EST 2007


> Yeah, it was really a hotfix. I hadn't thought about people wanting
> to ignore the error messages.  Here is what alpm_trans_commit calls:
> 
> alpm_trans_commit
>   -> _alpm_trans_commit
>     -> _alpm_sync_commit
>       -> test_delta_md5sum & test_pkg_md5sum
>         -> test_md5sum
>       -> _alpm_trans_prepare
>         -> _alpm_sync_prepare
>           -> _alpm_resolvedeps
> 
> 
> The only places I can find writing to data are without a if(data)
> block are: _alpm_trans_prepare
> _alpm_sync_prepare
> test_md5sum
> 
> The attached patch fixes those and thus should fixed the problem at
> its source.
> 

Great work!
The patch has just eliminated the segfault. Thanks.
Bye




More information about the pacman-dev mailing list