shiningxc at gmail.com
Sun Dec 23 14:08:53 EST 2007
Allan McRae wrote:
> I was looking at FS#7155 (http://bugs.archlinux.org/task/7155) which I
> believe to be fixed now but during then I notice some left overs from
> what appears to be a rewrite of the md5sum checking.
> In the bug report, it was asking for more information than "error:
> failed to commit transaction (invalid or corrupted package)". Trying to
> look at this I noticed that the "invalid of corrupted package" part can
> only generated by alpm_pkg_checkmd5sum() which is not used anywhere.
> The "error: failed to commit transaction" part is generated by
> sync_trans() if alpm_trans_commit() fails which in this case can be
> followed through to test_md5sum() failing. So it looks like md5sum
> checking was overhauled at some stage.
> So my question is: Is alpm_pkg_checkmd5sum() a leftover of the past and
> need removing?
I guess so, I didn't find yet when its usage was removed, but I at least
found when it was introduced.
It was first used in src/pacman/sync.c , with commit b708e448ea3 .
More information about the pacman-dev