[pacman-dev] CVS update of pacman-lib (14 files)

[Dan McGee]

On 2/17/07, Aaron Griffin <aaronmgriffin at gmail.com> wrote:
> On 2/17/07, Aaron Griffin <aaron at archlinux.org> wrote:
> > * A whole mess of backup changes
> >   - the code should be clearer, more organized, commented, and have worthwhile
> >     variable names now
> >   - proactive backup=()s now work.  That is, adding a file to a backup array
> >     does what it should on the upgrade to that package, no longer forcing you to
> >     wait a full upgrade cycle for it to take effect
>
> This needs some more testing to verify it's working 100% so I don't
> want push out another RC just yet... feel free to use the PKGBUILD at
> http://archlinux.org/~aaron/pacman/PKGBUILD if you want to build from
> CVS and test it.  It works in all the tests I did, but they weren't
> exhaustive tests.

More a coding style thing:
lib/libalpm/remove.c:
+		_alpm_pkg_update_depends(info, 1 /*is a remove*/);

Why do you need this remove parameter? You do things two different
ways in the function now- once using the remove value passed in, and
once like this:
if(handle->trans && handle->trans->packages
  	                          && handle->trans->type == PM_TRANS_TYPE_REMOVE) {

It seems like checking this at the top of the function and storing it
to a variable then would be more effective then having a "magic
parameter".

-Dan