[pacman-dev] CVS update of pacman-lib (TODO.dan src/pacman/sync.c)

[dan at archlinux.org]

    Date: Wednesday, February 21, 2007 @ 03:16:27
  Author: dan
    Path: /home/cvs-pacman/pacman-lib

Modified: TODO.dan (1.12 -> 1.13) src/pacman/sync.c (1.112 -> 1.113)

* Slight message change for consistancy- add a ' ' (space char) at the
  beginning to match the way other repos are displayed.
* TODO updates.


-------------------+
 TODO.dan          |   58 ++++++++++++++++++++++++++++++----------------------
 src/pacman/sync.c |    4 ++-
 2 files changed, 37 insertions(+), 25 deletions(-)


Index: pacman-lib/TODO.dan
diff -u pacman-lib/TODO.dan:1.12 pacman-lib/TODO.dan:1.13
--- pacman-lib/TODO.dan:1.12	Mon Feb 19 21:14:27 2007
+++ pacman-lib/TODO.dan	Wed Feb 21 03:16:26 2007
@@ -4,19 +4,30 @@
 This is my personal TODO list. No guarantees if it is out of date and things no
 longer apply. If you want to help out with any of it, send me an email.
 
-Documentation- look into moving man page format to a more portable source
-format to make translation easier to keep up-to-date (something like txt2tags,
-docbook, asciidoc) This will need some research.
+Only vaguely related to pacman:
+-------------------------------
 
 Port the libdownload (libfetch) manpage from BSD style to Linux style, or at
 very least change references to BSD.
 
+
+Pacman 3.0:
+-----------
+
+ideas mentioned here- http://bbs.archlinux.org/viewtopic.php?id=29450- add a
+.install message about mirrors, maybe comment whole file, encourage rankmirrors
+usage
+
+
 Pacman 3.1:
-===========
+-----------
+
+Documentation- look into moving man page format to a more portable source
+format to make translation easier to keep up-to-date (something like txt2tags,
+docbook, asciidoc) This will need some research.
 
-Updated cache cleaning functionality in pacman - keep installed version, choose
-number to keep, etc. Good python script in the forums that we should try to
-emulate, perhaps.
+Update cache cleaning functionality - keep installed version, choose number to
+keep, etc. Good python script in the forums that we should try to emulate.
 
 Downgrade feature - allow users to see cached packages and downgrade to
 (previous or any?) available options.
@@ -26,7 +37,7 @@
 (example: sync,c, add.c, and deptest.c all contain a switch on PM_DEP_MOD_*).
 Merge update, add, and sync code when possible, so we reduce duplication.
 
-Review progress /transaction event subsystem. (from TODO)
+Review progress/transaction event subsystem. (from TODO)
 
 Add Doxygen comments to every function in libalpm including private functions.
 Ensure functions are doing exactly their purpose and nothing more. Find
@@ -68,33 +79,24 @@
 
 Localize the date display done in --info output. Also, fix other localized
 issues- use non-printf when necessary, make sure all two line printed messages
-(especially usage instructions) are printed using one print statement.
+(especially usage instructions) are printed using one print statement. We
+may need to use some wchar_t output on the progress bar as char/byte counts
+differ here.
 
 Rewrite makepkg to use terminal-safe coloring/bolding. tput utility should
 allow us to do this.
 
-Other ideas:
-============
+Other smaller things:
+---------------------
 
 unsigned int vs. unsigned- determine a standard and stick with it
 
-Possibly split utilities/extras from pacman package
-
 FS #4185 - move where message is logged, perhaps?
 
-ideas mentioned here- http://bbs.archlinux.org/viewtopic.php?id=29450- add a
-.install message about mirrors, maybe comment whole file, encourage rankmirrors
-usage
-
 Update copyrights (2007)
 
 Update pacman website, and add/finish pacman coding style page
 
-Make .indent.pro file for GNU indent (started, but didn't finish)
-
-Pacman 3 packaging - perhaps include pacman2.static in case something goes
-terribly wrong, which I hope it won't
-
 autogen.sh / autoclean.sh - these seem messy. Can we clean this up?
 
 Refine makepkg error codes. Each kind of failure could have its own code:
@@ -114,8 +116,9 @@
 
 --print-uri option to sync should not require saying yes or no to up to date
 
-Resurrect test scripts, and add ones as needed. Testing by scripts > testing by
-hand.
+Add testing scripts to pactest for issues we have been working on (especially 
+files moving between packages). Also, take a look at cleaning up the output and
+structure of the pactest.py program itself.
 
 Build a replacement for this, or at least standardize its use. We shouldn't
 always need to pass handle->root around, it is constant. Something like char*
@@ -123,3 +126,10 @@
 	/* build the new entryname relative to handle->root */
 	snprintf(filename, PATH_MAX, "%s%s", handle->root, entryname);
 
+Random ideas:
+-------------
+
+Possibly split utilities/extras from pacman package
+
+Make .indent.pro file for GNU indent (started, but didn't finish)
+
Index: pacman-lib/src/pacman/sync.c
diff -u pacman-lib/src/pacman/sync.c:1.112 pacman-lib/src/pacman/sync.c:1.113
--- pacman-lib/src/pacman/sync.c:1.112	Thu Feb 15 21:21:13 2007
+++ pacman-lib/src/pacman/sync.c	Wed Feb 21 03:16:26 2007
@@ -39,6 +39,8 @@
 #include <alpm.h>
 #include <alpm_list.h>
 #include <download.h> /* downloadLastErrString */
+/* TODO remove above download.h inclusion once we abstract more, and also
+ * remove it from Makefile.am on the pacman side */
 /* pacman */
 #include "util.h"
 #include "log.h"
@@ -660,7 +662,7 @@
 	packages = alpm_trans_get_packages();
 	if(packages == NULL) {
 		/* nothing to do: just exit without complaining */
-		MSG(NL, _("local database is up to date\n"));
+		MSG(NL, _(" local database is up to date\n"));
 		goto cleanup;
 	}