[pacman-dev] [patch] _alpm_remove_commit refactoring
seinfeld90 at gmail.com
Mon Jan 15 22:22:51 EST 2007
* Dan McGee <dpmcgee at gmail.com> [070115 22:04]:
> On 1/15/07, James Rosten <seinfeld90 at gmail.com> wrote:
> > This is my refactoring of _alpm_remove_commit in remove.c.
> Hey, I touched up your patch a bit. First, I made your new function
> static because it is not needed outside remove.c. This allows the
> compiler to possibly optimize better, and keeps the code sane. You'll
> also notice that the function is no longer listed in the header file
> because of this.
> You also made a few small typo errors, but the effort was there :).
> May want to try compiling next time.
Thanks Dan. I made int position a pointer as a last change realizing its value
needed to be kept and I guess I forgot about changing the stuff involving
(revising is something I should work on probably :P, might help my English grade
~ Jamie / yankees26
More information about the pacman-dev