[pacman-dev] makepkg and NOT extracting netfiles

[Jürgen Hötzel]

On Tue, Jan 23, 2007 at 12:40:21AM -0500, James Rosten wrote:
>  unset LC_ALL LANG
> @@ -680,7 +680,17 @@
>     msg "Extracting Sources..."
>     for netfile in "${source[@]}"; do
>         unziphack=0
> +       NoExtract=0
>         file=$(strip_url "$netfile")
> +       for skipfile in "${noextract[@]}"; do
> +           if [ "$skipfile" = "$file" ]; then
> +               NoExtract=1
> +               break;
> +           fi
> +       done
> +       if [ $NoExtract -eq 1 ]; then
> +           continue;
> +       fi
>         # fix flyspray #6246
>         file_type=$(file -biz "$file")

file-pattern-only was much clearer. You never want to extract JAR files).

Awesome. Much complexity just to guess right how the package maintainer
wants to prepare the sources. This should be moved into a single function
lookIntoTheCrystalBallAndExtractSources(). Not really KISS.

What about reverting to the old default behaviour and making source
extraction part of the maintainers build() function or provide a default
prep() function (too keep older PKGBUILDs working) which is called before
build() and let the maintainer redefine prep() to override the default
behaviour.

Jürgen
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://archlinux.org/pipermail/pacman-dev/attachments/20070123/cea1b696/attachment.pgp>