[pacman-dev] [patch] remove use of unsigned char for enums, convert #define constants to enums

Johannes Weiner hannes at saeurebad.de
Tue Jan 23 16:43:38 EST 2007


On Fri, Jan 19, 2007 at 09:54:16PM -0500, Dan McGee wrote:
> This mainly deals with code clarity- removing currently unneeded
> optimizations in order to make the code much more readable and
> type-checkable. Every enum in the library now has it's own type that
> should be used instead of the generic 'unsigned char'. In addition,
> several #define statements dealing with constants were converted to
> enums.

Uh.. what do you need all this types for...?

There are currently 30 custom types over the lib (IIGC). Does this
really bring more clarity?

Do you need to typecheck an error-level?



More information about the pacman-dev mailing list