[pacman-dev] [patch] makepkg3 -- cleanup dep check functions

Andrew Fyfe andrew at neptune-one.net
Fri Jun 1 12:18:26 EDT 2007


Dan McGee wrote:
> On 6/1/07, Andrew Fyfe <andrew at neptune-one.net> wrote:
>> Oops, I was using working for something else, I've put the makepkg
>> branch up, all the patches are there.
>>
>> Andrew
> 
> While looking this over, I've noticed that we are calling exit an
> awful lot from the functions. Shouldn't we contain the exit calls to
> the main body of code, and use return statements to get the control
> back to there to do the actual exiting? Just a thought, comments
> welcome.
> 
> -Dan
> 
> _______________________________________________
> pacman-dev mailing list
> pacman-dev at archlinux.org
> http://archlinux.org/mailman/listinfo/pacman-dev

Just for the record makepkg contains 54 :o exit calls

Andrew





More information about the pacman-dev mailing list