[pacman-dev] [patch] alpm_splitdep overwrites input string

[Dan McGee]

On 6/18/07, Xavier <shiningxc at gmail.com> wrote:
> Nice catch, thanks a lot.
>
> But while sync300 now pass, what the code does looks still odd.
> It first calls resolvedeps, which calls checkdeps. This returns the
> missing dependency pkg2=1.1 .
> But for resolving it, resolvedeps pull pkg2 1.0 , without checking the version.
>
> However, checkdeps is called again after resolvedeps, which now finds
> the problem that pkg1 depends on pkg2=1.1 which isn't available.
> Before you fixed that bug in splitdep, it changed the pkg2=1.1
> dependency into pkg2 the first time checkdeps was called. So it didn't
> find the problem the second time.
>
> As you said the first time you described the problem, resolvedeps
> should probably checks version too, when it tries to resolve the
> missing dependencies.

I'm going to push this patch to my local tree. Do we need to do
changes elsewhere that relied on this previous broken behavior?

-Dan