[pacman-dev] [PATCH] Change the exit code for pacman_deptest() and some clean up.

Xavier shiningxc at gmail.com
Fri Jun 29 09:42:18 EDT 2007


2007/6/29, Andrew Fyfe <andrew at neptune-one.net>:

> I need to do some more research before playing with the code :) I saw
> the comment in pacman_deptest() and assumed there was still a problem
> with alpm_splitdeps().
>
> >
> > I just find this code in pacman_deptest rather curious, because it
> > indeed looks out of place. So I think your patch for this function is
> > correct.
> >
> > Ah one little thing, I wonder if this free(saved_target) that you
> > already removed
> > could be replaced by free(dep).
> Done :)
>

Another thing I missed earlier, why is this deps.h needed ?
Isn't it only in the backend anyway ? I don't think pacman should have
access to it.

Otherwise, I think it's fine now :) But since I don't have enough
experience either,
it would be better if someone looked at it also :D




More information about the pacman-dev mailing list