[pacman-dev] [PATCH] Change the exit code for pacman_deptest() and some clean up.
Xavier
shiningxc at gmail.com
Sat Jun 30 19:03:24 EDT 2007
2007/6/30, Andrew Fyfe <andrew at neptune-one.net>:
>
> I added deps.h so that I could access pmdepend_t->name, at the moment
> deptest is passing target (which could = foobar>=1.0) where the
> functions are expecting just the package name. So deptest is useless
> when dealing with versioned deps at the moment.
>
Yes indeed, that code is now totally broken, because it relied on a
broken behavior, which has been fixed.
> Looking a little deeper I think pacman_deptest() should be using
> _alpm_checkdeps().
That search for satisfier done by pacman_deptest() is very very
common, and used everywhere, so there is some factoring work to do.
There is no function for doing it yet, but there should be one. See
third paragraph of Nagy's mail there :
http://www.archlinux.org/pipermail/pacman-dev/2007-June/008539.html
> Are all _* functions private?
Yes _alpm_* functions are private, while alpm_* functions are made
public by the SYMEXPORT attribute. for example :
lib/libalpm/deps.c:pmdepend_t SYMEXPORT *alpm_splitdep(const char *depstring)
More information about the pacman-dev
mailing list