[pacman-dev] [PATCH] Integrate versionpkg into makepkg

[Dan McGee]

On Nov 5, 2007 1:56 AM, Xilon <xilonmu at gmail.com> wrote:
> On Oct 30, 2007 11:28 PM, Xilon <xilonmu at gmail.com> wrote:
> >
> > On Oct 30, 2007 2:54 AM, Scott Horowitz <stonecrest at gmail.com> wrote:
> > > Aside from the handling of darcs and git, I should point out that
> > > there seems to be some disagreement about the handling of mercurial.
> > > It appears that someone filed a bug report, a line was added to
> > > versionpkg's code to handle it, and someone else is having problems
> > > with that extra line.
> > >
> > > See:
> > > http://bugs.archlinux.org/task/7606
> > >
> > > and:
> > > http://aur.archlinux.org/packages.php?do_Details=1&ID=9272 (second
> > > comment, by Xilon)
> > >
> > > Scott
> > >
> > >
> > > _______________________________________________
> > > pacman-dev mailing list
> > > pacman-dev at archlinux.org
> > > http://archlinux.org/mailman/listinfo/pacman-dev
> > >
> >
> > The bug filed is only due to the src directory not being there. I
> > don't know how creating the $_hgrepo directory solved the problem,
> > since mercurial simply doesn't support initting or cloning a repo to a
> > directory that exists. A proper solution would be to create the src
> > directory if it doesn't exist, or wrap the whole path with dirname to
> > remove the last directory.
> >
>
> Here's a patch which should fix both issues, though I haven't run into
> the other one mention for which a bug was filled, so I was unable to
> test it. I have tested the patch for subtle-hg and abraca-hg, both
> cloning and updating works.
> I also removed the pointless "make clean", the PKGBUILDs should be
> building in another directory anyway, as the guidelines suggest.

Thanks for this, I've pulled it into my working branch. And good catch
with the "make clean"- we should never do that in makepkg.

-Dan