[pacman-dev] [PATCH] Allow xdelta options to be set per package.

[Dan McGee]

On Nov 8, 2007 4:10 PM, Nathan Jones <nathanj at insightbb.com> wrote:
> On Thu, Nov 08, 2007 at 03:50:12PM -0600, Dan McGee wrote:
> > On Nov 8, 2007 3:36 PM, Nathan Jones <nathanj at insightbb.com> wrote:
> > > On Thu, Nov 08, 2007 at 01:46:34PM -0600, Aaron Griffin wrote:
> > > > On Nov 8, 2007 1:37 PM, Nathan Jones <nathanj at insightbb.com> wrote:
> > > > > Setting xdelta (or !xdelta) in the options array in a PKGBUILD will
> > > > > override the makepkg.conf setting.
> > > >
> > > > So this means we can generate deltas on a package by package basis,
> > > > like for OpenOffice or the like, correct?
> > > >
> > > > The reason I ask is... well, if it's per-package now, do we really
> > > > need a buildenv option for this as well?
> > >
> > > If a person maintains 100 packages and decides to start creating deltas,
> > > I would think he would prefer to add xdelta to makepkg.conf rather than
> > > to 100 different PKGBUILDs.
>
> I think I misunderstood you. Are you suggesting to move the xdelta
> option from BUILDENV array to the OPTIONS array? If so, I think that
> is a good idea.

Here is how the two arrays were meant to work (I think):
BUILDENV- these are things that affect the building of the package,
but NOT the package contents (ccache or distcc should in theory not
affect the compiled product).
OPTIONS- these are things that affect the actual package contents
(removing man pages and stripping binaries produce a different package
than one built without those options).

So with that out there, I think xdelta should stay in BUILDENV.
Apparantly we made a decision a while back to not have both an
options=() and a buildenv=() array in the PKGBUILD, so those options
and environment settings are all smashed into one array.

-Dan