[pacman-dev] [PATCH] alpm_list_add == alpm_list_add_last I: recursedeps clean-up

Dan McGee dpmcgee at gmail.com
Wed Nov 14 09:01:50 EST 2007

On Nov 14, 2007 6:18 AM, Nagy Gabor <ngaba at bibl.u-szeged.hu> wrote:
> Hi!
> Patch attached. See the patch description for details.
> Bye, ngaba

Seems OK to me, anyone else see anything weird here? I've applied it locally.

Nagy- two small favors to ask of you for future patches. And this is
really for anyone on the list, but I just noticed it here:
1. git-am likes it a lot better if you format your commit message with
the subject, then a *blank line* (not just a newline), and then the
commit message.
2. Can you please try to use punctuation where it seems appropritate?
I'm fine with having to fix up some English usage stuff, but
punctuation makes it easier for us all to read the first time around.
This applies to both commit messages and comments in the code (such as
the doxygen comment in this patch).


More information about the pacman-dev mailing list