[pacman-dev] [PATCH] Add ShowOldVersion Option

Justin Lampley jrlampley at gmail.com
Wed Nov 14 13:07:20 EST 2007

Dan McGee wrote:

> VerboseTargetInfoList? Ha. Figure out something shorter along those
> lines and its good with me.
> +1 from me if anyone wants to whip this up. It would also keep us down
> to one option instead of having to worry about combinations of
> options. Be sure to update the manpage while you are at it. I'll hold
> off on merging the other patch, so feel free to make it against the
> current master.
> You'll have to figure out the column sizes somehow, not sure how that
> magic should work. And looking at Justin's original patch, make sure
> the "New" string is gettext-ed (and you don't make any assumptions
> about it only being 3 chars). His refactoring was also nice, although
> this will need to be a slightly different code layout.
> -Dan
> _______________________________________________
> pacman-dev mailing list
> pacman-dev at archlinux.org
> http://archlinux.org/mailman/listinfo/pacman-dev
First of all, attached is an update of the original patch with a 
possible bug
Initially I tried to take depends and such into account by checking  if 
the data
was  NULL in the sync package.  Turns out there is a much easier way, check
the sync type for PM_SYNC_TYPE_UPGRADE (duh!), if it isn't an upgrade
then assume it is new.  This cleans up the code a bit, and I believe the 
way might have had some instances where a non-upgrade would get through
and garbage would be printed.

I will try to take a stab at creating the columned output, but like Dan, 
I do
not know exactly how I will get it to work, if someone else has a great 
feel free to beat me to the implementation of this new output scheme.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-a-configuration-option-to-allow-displaying-of.patch
Type: text/x-patch
Size: 4765 bytes
Desc: not available
URL: <http://archlinux.org/pipermail/pacman-dev/attachments/20071114/41c0b915/attachment.bin>

More information about the pacman-dev mailing list