[pacman-dev] IgnorePkg handling
shiningxc at gmail.com
Fri Nov 16 09:54:51 EST 2007
On Fri, Nov 16, 2007 at 12:39:47PM +0100, Xavier wrote:
> Yes, that looks fine.
> I should probably check the other places where should_ignore is used though.
I rather looked at where compare_versions was used. Only three times, two in
sync.c (sysupgrade and addtarget) and one in db.c (get_upgrades duplicated
In sysupgrade, there was, as I mentioned, an additional ignore check that was
no longer used.
In get_upgrades, there wasn't anything.
And finally, in addtarget, there was a special ignore handling.
So based on that, I thought the ignorepkg handling could be as well removed
from compare_versions, and handled manually by the callers.
By the way, isn't it rather strange that the ignorepkg handling in addtarget is made only
when the package is locally installed?
For example :
> sudo pacman -S bash --ignore bash
:: bash is in IgnorePkg/IgnoreGroup. Install anyway? [Y/n] n
> sudo pacman -S arts --ignore arts
resolving dependencies... done.
looking for inter-conflicts... done.
Targets: xdg-utils-1.0.2-1 archlinux-menus-1.2-1 kde-common-3.5.8-1 audiofile-0.2.6-3 esd-0.2.38-3 arts-1.5.8-2
Total Download Size: 1.74 MB
Proceed with installation? [Y/n]
More information about the pacman-dev