[pacman-dev] Holy inefficient batman!

Nagy Gabor ngaba at bibl.u-szeged.hu
Mon Nov 19 05:58:30 EST 2007

> > 2. I found a hidden alpm_dep_get_string _alpm_checkdeps patch in your
> patch:
> > Avoiding alpm_dep_get_string usage in debug messages was purposeful by me,
> not 
> > negligency (I refer to http://projects.archlinux.org/git/?
> > p=pacman.git;a=commit;h=d903fc607ee2aa2527202f1e54a44be325eabe48 here)
> > I don't want to waste time for formatting debug messages (I prefer only
> O(1) 
> > debug preformat), see also: 3.
> I indeed thought this was a negligency. It didn't seem to work for me.
> For example when running the add045 pactest, I got messages like :
> [19:17:19] debug: missing dependency '' for package 'pkg1'
> I switched to alpm_dep_get_string usage and it worked fine.
Well, I totally overlooked something (again), sry;-)
I should have blamed Dan;-P: His alpm_splitdep removal broke this, when my patch
was sent j->data stored the dependency string, now it stores pmdeptype_t

SZTE Egyetemi Könyvtár - http://www.bibl.u-szeged.hu
This mail sent through IMP: http://horde.org/imp/

More information about the pacman-dev mailing list