[pacman-dev] [PATCH] Fix alpm_list_add_sorted

[Nagy Gabor]

> On Nov 13, 2007 11:21 AM, Aaron Griffin <aaronmgriffin at gmail.com> wrote:
> > On Nov 13, 2007 11:01 AM, Nagy Gabor <ngaba at bibl.u-szeged.hu> wrote:
> > > Hi!
> > > Patch attached.
> >
> > Could you explain exactly what this is fixing? The subject just says
> > "fix" - is this something I missed with the tail pointer changes?
> >
> > Other than that, I think we're good. It looks... ok to me.
> >
> > And, for the record, I have to point out that I don't like comments
> > like this, heh:
> > +               /* set add->next */
> >                 add->next = next;
> 
> Aaron- I was going to let you run with this.

Well, I can admit that my patch is quite hard-to-read. I wanted to keep the old
style but the result is quite unreadable; probably a head-case, tail-case,
middle-case would have been better...
So I won't be aggrieved etc., if you rework it: this is teamwork. (I won't
rewrite it, because it works(?), and code readability is not an argument for me.)
Bye


----------------------------------------------------
SZTE Egyetemi Könyvtár - http://www.bibl.u-szeged.hu
This mail sent through IMP: http://horde.org/imp/