[pacman-dev] [PATCH] Fix several memleaks, mostly related to errors handling.

Nagy Gabor ngaba at bibl.u-szeged.hu
Sat Nov 24 08:00:53 EST 2007

Good catches!

> * in _alpm_sync_prepare, the deps and asked lists were not freed in case
> of errors (unresolvable conflicts).
> Besides the code for handling this case was duplicated.

The good old sync.c: probably you can find more bugs in sync_prepare monster;-)
I don't want to hurt anyone, but I couldn't find any concept in sync_prepare [as
I said earlier: that looks a bunch of #FS fixes instead]. The asked list is
totally needless for example...

So I suggest again rewriting it from scratch (with or without using my pending
patches) <- it is easier then review the current code imho.


SZTE Egyetemi Könyvtár - http://www.bibl.u-szeged.hu
This mail sent through IMP: http://horde.org/imp/

More information about the pacman-dev mailing list