[pacman-dev] [PATCH] pacman/query.c : -Qo optimization.

Aaron Griffin aaronmgriffin at gmail.com
Mon Nov 26 16:09:44 EST 2007


On Nov 25, 2007 2:24 PM, Dan McGee <dpmcgee at gmail.com> wrote:
> I feel like their could be an edge case where something breaks and
> this shortcut bites us. However, I can't figure out out. Anyone else?
> Otherwise this makes a lot of sense.

I don't think so.

operation 1 : check basename
if same
    operation 2 : check full path
        if same
            tada!

The only edge cases are when basename matches, but the full path does
not, which is covered anyway.

Personally, I think this is a brilliant idea on Xavier's part, so keep
up the good work.

Also, make sure to note what Dan mentioned about basename (we want to
try and be cross-platform here whenever possible)




More information about the pacman-dev mailing list