[pacman-dev] [PATCH] alpm_checkdeps clean-up

[Aaron Griffin]

On Nov 30, 2007 8:37 AM, Dan McGee <dpmcgee at gmail.com> wrote:
> On Nov 30, 2007 12:45 AM, Xavier <shiningxc at gmail.com> wrote:
> > On Fri, Nov 30, 2007 at 12:10:33AM -0600, Aaron Griffin wrote:
> > > On Nov 29, 2007 6:59 AM, Nagy Gabor <ngaba at bibl.u-szeged.hu> wrote:
> > > > Patch attached
> > >
> > > Yay, simpler code is always fun. This looks MUCH simpler.
> > >
> > > It's a big chunk of changes to digest, but I think it all looks good.
> > > At least all the pactests pass - anyone have an opinion here?
> > >
> >
> > Having a more careful look at it is on my TODO list for the next few days :)
> > But if you think it's fine, you can always merge it, and I'll review it
> > later.
>
> I'll be looking at it this weekend for sure. The "check localdb by
> hand" comment scares me a bit, but I haven't dove into the code yet.

Yeah, I did a rough review. It looked well done, so I applied and
checked, and got no errors, but I do need to do a side-by-side
compare. I was hoping someone else did already 8)