[pacman-dev] [patch] testdb, reworked

Xavier shiningxc at gmail.com
Wed Oct 10 08:59:33 EDT 2007


On Tue, Oct 09, 2007 at 11:55:47AM +0200, Nagy Gabor wrote:
> Hi!
> I had to rewrite the patch, because I found a new bug in testdb.c:
> Using alpm_list_msort broke requiredby lists in pkgcache (you can test this by
> duplicating the requiredby-test code), so I fixed this, too.
> Patch attached, bye.
> 

Oh, I see, what I did is pretty bad : I directly modified (sorted) the requiredby
fields from each package.. Without updating the head of the list stored in
pkg->requiredby. I don't think it's possible to edit pkg->requiredby anyway,
but that might be a good thing.

So the list should probably be copied first, before sorting it, right?




More information about the pacman-dev mailing list